Add filename property #1571
Open
Add filename property #1571
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 19 commits
September 20, 2024 17:18
Adding comments with examples of each header type in ephy_testing_data.
Now tests for existence of the patterns and produces error or None values as appropriate.
|
Thanks Peter. Sam said he would review this when he has some time. So I assigned him to all of these and he will be the main reviewer. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds the OriginalFileName property to the NlxHeader. Also cleans up private members and moves a useful method to NlxHeader from test.
This is the last in this sequence of commits for a while now. This now provides a much clearer method of parsing the header which works with all extant files (@JuliaSprenger and thus provides that refactoring discussed a while back ;-). It should be more flexible for future possible variations and easier to modify if needed.
If one wanted to squish all of these since the divergence to master there would be much cleaner code to review, however, it would be major changes in one shot.